[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3a3c6241-2134-42d0-8dd3-0c96d8e7300b@lunn.ch>
Date: Thu, 11 May 2023 17:49:10 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Pranavi Somisetty <pranavi.somisetty@....com>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...rochip.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, richardcochran@...il.com, linux@...linux.org.uk,
palmer@...belt.com, git@....com, michal.simek@....com,
harini.katakam@....com, radhey.shyam.pandey@....com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH net-next v2 2/2] net: macb: Add support for partial store
and forward
> + if (GEM_BFEXT(PBUF_CUTTHRU, gem_readl(bp, DCFG6))) {
> + if (bp->caps & MACB_CAPS_PARTIAL_STORE_FORWARD) {
> + retval = of_property_read_u16(bp->pdev->dev.of_node,
> + "rx-watermark",
> + &bp->rx_watermark);
> +
> + /* Disable partial store and forward in case of error or
> + * invalid watermark value
> + */
> + wtrmrk_rst_val = (1 << (GEM_BFEXT(RX_PBUF_ADDR, gem_readl(bp, DCFG2)))) - 1;
> + if (retval || bp->rx_watermark > wtrmrk_rst_val || !bp->rx_watermark) {
> + if (bp->rx_watermark > wtrmrk_rst_val) {
> + dev_info(&bp->pdev->dev, "Invalid watermark value\n");
> + bp->rx_watermark = 0;
Please return -EINVAL. We want the DT author to fix their error.
> + }
> + dev_info(&bp->pdev->dev, "Not enabling partial store and forward\n");
The DT property is optional? So when it is missing, retval will be
-EINVAL. Please don't spam the logs in this case.
Andrew
Powered by blists - more mailing lists