[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87ednm4zux.wl-tiwai@suse.de>
Date: Thu, 11 May 2023 18:06:14 +0200
From: Takashi Iwai <tiwai@...e.de>
To: nemesis@...quake.net
Cc: alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
Stefan Binding <sbinding@...nsource.cirrus.com>,
Meng Tang <tangmeng@...ontech.com>,
Andy Chi <andy.chi@...onical.com>,
"Luke D. Jones" <luke@...nes.dev>,
Philipp Jungkamp <p.jungkamp@....net>,
Kacper Michajłow <kasper93@...il.com>,
Yuchi Yang <yangyuchi66@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15
On Wed, 10 May 2023 18:19:08 +0200,
Ryan C. Underwood wrote:
>
>
> The Pavilion 15 line has B&O top speakers similar to the x360 and
> applying the same profile produces good sound. Without this, the sound
> would be tinny and underpowered without either applying
> model=alc295-hp-x360 or booting another OS first.
The code change looks OK, but could you give your Signed-off-by tag?
It's a legal requirement and mandatory for merging to the upstream.
Also, you can reduce the recipients in Cc a bit more.
For this kind of trivial change, just maintainers and ML should
suffice.
thanks,
Takashi
Powered by blists - more mailing lists