linux-kernel - Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 May 2023 18:39:05 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Marco Elver <elver@...gle.com>,
        Michael Ellerman <mpe@...erman.id.au>
CC:     Dmitry Vyukov <dvyukov@...gle.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
        Rohan McLure <rmclure@...ux.ibm.com>
Subject: Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32
 bits architectures



Le 12/05/2023 à 18:09, Marco Elver a écrit :
> On Fri, 12 May 2023 at 17:31, Christophe Leroy
> <christophe.leroy@...roup.eu> wrote:
>>
>> Activating KCSAN on a 32 bits architecture leads to the following
>> link-time failure:
>>
>>      LD      .tmp_vmlinux.kallsyms1
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_load':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_load_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_store':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_store_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_exchange':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_exchange_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_add':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_add_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_sub':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_sub_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_and':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_and_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_or':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_or_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_xor':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_xor_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_nand':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_nand_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_strong':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_weak':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
>>    powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_val':
>>    kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
>>
>> 32 bits architectures don't have 64 bits atomic builtins. Only
>> include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures.
>>
>> Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins")
>> Suggested-by: Marco Elver <elver@...gle.com>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> Reviewed-by: Marco Elver <elver@...gle.com>
> 
> Do you have your own tree to take this through with the other patches?

I don't have my own tree but I guess that it can be taken by Michael for 
6.5 via powerpc tree with acks from you and Max.

Michael is that ok for you ?

Christophe