linux-kernel - [PATCH 1/1] dmaengine: dw-axi-dmac: drop useless apb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 12 May 2023 23:30:46 +0300
From:   Maxim Kochetkov <fido_max@...ox.ru>
To:     dmaengine@...r.kernel.org
Cc:     Maxim Kochetkov <fido_max@...ox.ru>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>, linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] dmaengine: dw-axi-dmac: drop useless apb_regs messages

If apb_regs is not used then drivers prints useless message in
console in every transaction:

[  217.527569] dw_axi_dmac_platform 10000000.sys-axi-dma: apb_regs not initialized

Drop this message printing to reduce console noise.

Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
---
 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index 6937cc0c0b65..d6899481803a 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -356,7 +356,6 @@ static void dw_axi_dma_set_byte_halfword(struct axi_dma_chan *chan, bool set)
 	u32 reg_width, val;
 
 	if (!chan->chip->apb_regs) {
-		dev_dbg(chan->chip->dev, "apb_regs not initialized\n");
 		return;
 	}
 
@@ -523,7 +522,6 @@ static void dw_axi_dma_set_hw_channel(struct axi_dma_chan *chan, bool set)
 	unsigned long reg_value, val;
 
 	if (!chip->apb_regs) {
-		dev_err(chip->dev, "apb_regs not initialized\n");
 		return;
 	}
 
-- 
2.39.2