linux-kernel - Re: [PATCH RFC] kthread: Unify kernel_thread() and user_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230512165309.896e063a9398639250eab264@linux-foundation.org>
Date:   Fri, 12 May 2023 16:53:09 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Huacai Chen <chenhuacai@...ngson.cn>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Kees Cook <keescook@...omium.org>, chenhuacai@...nel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] kthread: Unify kernel_thread() and
 user_mode_thread()

On Tue,  9 May 2023 18:41:27 +0800 Huacai Chen <chenhuacai@...ngson.cn> wrote:

> Commit 343f4c49f2438d8 ("kthread: Don't allocate kthread_struct for init
> and umh") introduces a new function user_mode_thread() for init and umh.
> But the name is a bit confusing because init and umh are indeed kernel
> threads at creation time, the real difference is "they will become user
> processes". So let's unify the kernel_thread() and user_mode_thread() to
> kernel_thread() again, and add a new 'user' parameter for init and umh.
> 
> ...
>
>  5 files changed, 9 insertions(+), 26 deletions(-)
>

Less code is nice.

> -extern pid_t user_mode_thread(int (*fn)(void *), void *arg, unsigned long flags);
> +			    unsigned long flags, int user);

`bool user'?