linux-kernel - Re: Re: [PATCH] xfs: xfs_nfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230512060204.GC3223426@dread.disaster.area>
Date:   Fri, 12 May 2023 16:02:04 +1000
From:   Dave Chinner <david@...morbit.com>
To:     "renlei1@...natelecom.cn" <renlei1@...natelecom.cn>
Cc:     "Darrick J. Wong" <djwong@...nel.org>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] xfs: xfs_nfs_get_inode support zero generation

On Fri, May 12, 2023 at 10:53:29AM +0800, renlei1@...natelecom.cn wrote:
> Yup, gen is 0 for the inodes created by libxfs, such as rootino, rbmino, rsumino.
> but those inodes will never be freed, and gen will always zero.

Yes, but why does that even matter for file handle verification?

> so I think bypass the verification if gen==0 is still valid.

Did you think about what happens when an inode->gen
overflows from 0xffffffff to 0 as part of a normal unlink/create
cycle?

-Dave.
-- 
Dave Chinner
david@...morbit.com