lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2cff10cae88067f8bc952a57b231c75f0009a982.camel@mediatek.com>
Date:   Fri, 12 May 2023 07:53:27 +0000
From:   Yi-De Wu (吳一德) <Yi-De.Wu@...iatek.com>
To:     "corbet@....net" <corbet@....net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        Yingshiuan Pan (潘穎軒) 
        <Yingshiuan.Pan@...iatek.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "will@...nel.org" <will@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        MY Chuang (莊明躍) <MY.Chuang@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        PeiLun Suei (隋培倫) 
        <PeiLun.Suei@...iatek.com>,
        Liju-clr Chen (陳麗如) 
        <Liju-clr.Chen@...iatek.com>,
        Jades Shih (施向玨) 
        <jades.shih@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Shawn Hsiao (蕭志祥) 
        <shawn.hsiao@...iatek.com>,
        Miles Chen (陳民樺) 
        <Miles.Chen@...iatek.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Ivan Tseng (曾志軒) 
        <ivan.tseng@...iatek.com>,
        Ze-yu Wang (王澤宇) 
        <Ze-yu.Wang@...iatek.com>
Subject: Re: [PATCH v1 3/6] soc: mediatek: virt: geniezone: Introduce
 GenieZone hypervisor support

On Fri, 2023-04-14 at 12:48 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 14/04/23 10:43, Yi-De Wu (吳一德) ha scritto:
> > On Thu, 2023-04-13 at 19:08 +0200, Matthias Brugger wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On 13/04/2023 14:55, Krzysztof Kozlowski wrote:
> > > > On 13/04/2023 11:07, Yi-De Wu wrote:
> > > > > From: "Yingshiuan Pan" <yingshiuan.pan@...iatek.com>
> > > > > 
> > > > > GenieZone is MediaTek proprietary hypervisor solution, and it
> > > > > is
> > > > > running
> > > > > in EL2 stand alone as a type-I hypervisor. This patch exports
> > > > > a
> > > > > set of
> > > > > ioctl interfaces for userspace VMM (e.g., crosvm) to operate
> > > > > guest VMs
> > > > > lifecycle (creation, running, and destroy) on GenieZone.
> > > > > 
> > > > > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> > > > > Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> > > > > ---
> > > > >    arch/arm64/include/uapi/asm/gzvm_arch.h       |  79 ++++
> > > > >    drivers/soc/mediatek/Kconfig                  |   2 +
> > > > >    drivers/soc/mediatek/Makefile                 |   1 +
> > > > >    drivers/soc/mediatek/virt/geniezone/Kconfig   |  17 +
> > > > 
> > > > Hypervisor drivers do not go to soc. Stop shoving there
> > > > everything
> > > > from
> > > > your downstream. Find appropriate directory, e.g. maybe
> > > > drivers/virt.
> > > 
> > > Acked, what is the reason you want to add this to drivers/soc
> > > instead
> > > of
> > > drivers/virt?
> > > 
> > > Regards,
> > > Matthias
> > > 
> > 
> > Noted. We would take your advice and move it from
> > drivers/soc/mediatek/virt to /drivers/virt on next version.
> > 
> > The reason we put it under our soc/ is that the drver is highly
> > propietary for mediatek's product and for aarch64 only. Maybe it's
> > not
> > general enough to put in under /drivers/virt.
> 
> This is the same reason why mediatek-drm is in drivers/gpu/drm/ and
> the same why
> mediatek-cpufreq is in drivers/cpufreq/.
> 
> I know that this is a MediaTek specific implementation, but it *is* a
> hypervisor
> driver, hence it belongs to the hypervisor drivers folder.
> It's not even granted that this will not support other MediaTek
> architectures in
> the future, but that's not a discussion to do right here and right
> now, and it's
> anyway irrelevant in this moment.
> 
> By the way, good job with upstreaming your drivers targeting MediaTek
> Android SW!
> I'm enthusiast to see that.
> 
> Regards,
> Angelo
> 

Thank you Angelo, we've already separated the general and architecture
dependent implementations as you suggested and delivered in v2.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ