linux-kernel - Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e8073d1-d1f0-de1a-2331-913cbedafc29@quicinc.com>
Date:   Fri, 12 May 2023 14:26:33 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Bjorn Andersson <andersson@...nel.org>
CC:     <agross@...nel.org>, <konrad.dybcio@...aro.org>,
        <linus.walleij@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <richardcochran@...il.com>,
        <manivannan.sadhasivam@...aro.org>, <andy.shevchenko@...il.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct


On 5/11/2023 10:03 PM, Bjorn Andersson wrote:
> On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote:
>> Remove the msm_function struct to reuse the generic pinfunction
>> struct. Also, define a generic PINFUNCTION macro that can be used across
>> qcom target specific pinctrl files to avoid code repetition.
>>
> Looks nice! No need to carry our own structs for things that has made it
> into the framework.
>
> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
>
> But, ipq9574.c has made it into linux-next now, so this breaks the build
> of that driver. So please update this patch. And please send the two
> refactoring patches on their own, followed by the SDX75 based on that,
> so we can get those merged quickly, before any other impediments are
> introduced.
Sure, Will the refactoring patches independently rebased on linux-next.

Thanks,
Rohit.
>
> Regards,
> Bjorn