[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230511180608.6e1f6620@kernel.org>
Date: Thu, 11 May 2023 18:06:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenz Brun <lorenz@...n.one>
Cc: Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
Sean Wang <sean.wang@...iatek.com>,
Mark Lee <Mark-MC.Lee@...iatek.com>,
Lorenzo Bianconi <lorenzo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock
enable errors
On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote:
> for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> ret = clk_prepare_enable(eth->clks[clk]);
> - if (ret)
> + if (ret) {
> + dev_err(eth->dev, "enabling clock %s failed with error %d\n",
> + mtk_clks_source_name[clk], ret);
> goto err_disable_clks;
> + }
dev_err_probe() would be even better, I think?
--
pw-bot: cr
Powered by blists - more mailing lists