linux-kernel - Re: [PATCH v5] net: mdiobus: Add a function to deassert reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <KL1PR01MB54488021E5650ED8A203057FE6759@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Date:   Fri, 12 May 2023 17:28:47 +0800
From:   Yan Wang <rk.code@...look.com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] net: mdiobus: Add a function to deassert reset



On 5/12/2023 5:02 PM, Russell King (Oracle) wrote:
> On Fri, May 12, 2023 at 03:08:53PM +0800, Yan Wang wrote:
>> +	gpiod_set_value_cansleep(reset, gpiod_is_active_low(reset));
>> +	fsleep(reset_assert_delay);
>> +	gpiod_set_value_cansleep(reset, !gpiod_is_active_low(reset));
> Andrew, one of the phylib maintainers and thus is responsible for code
> in the area you are touching. Andrew has complained about the above
> which asserts and then deasserts reset on two occasions now, explained
> why it is wrong, but still the code persists in doing this.
>
> I am going to add my voice as another phylib maintainer to this and say
> NO to this code, for the exact same reasons that Andrew has given.
>
> You now have two people responsible for the code in question telling
> you that this is the wrong approach.
>
> Until this is addressed in some way, it is pointless you posting
> another version of this patch.
>
> Thanks.
>
I'm very sorry, I didn't have their previous intention.
The meaning of the two assertions is reset and reset release.
If you believe this is the wrong method, please ignore it.