linux-kernel - Re: [PATCH RESEND v5 01/14] PCI: dwc: Fix erroneous version type test helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230512102312.urrh2gwagopizn44@mobilestation>
Date:   Fri, 12 May 2023 13:23:12 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Vinod Koul <vkoul@...nel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND v5 01/14] PCI: dwc: Fix erroneous version type
 test helper

Hello Yoshihiro

On Fri, May 12, 2023 at 09:55:42AM +0000, Yoshihiro Shimoda wrote:
> Hi Serge,
> 
> > From: Serge Semin, Sent: Friday, May 12, 2023 4:09 AM
> > 
> > Due to an unfortunate mistake the macro function actually checks the
> > IP-core version instead of the IP-core version type which isn't what
> > originally implied. Fix it by introducing a new helper
> > __dw_pcie_ver_type_cmp() with the same semantic as the __dw_pcie_ver_cmp()
> > counterpart except it refers to the dw_pcie.type field in order to perform
> > the passed comparison operation.
> > 
> > Fixes: 0b0a780d52ad ("PCI: dwc: Add macros to compare Synopsys IP core versions")
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> I'm not sure whether my review is useful or not, but anyway,
> 
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

It's always useful. Thanks for looking into it.

Regards
-Serge(y)

> 
> Best regards,
> Yoshihiro Shimoda
> 
> > ---
> >  drivers/pci/controller/dwc/pcie-designware.h | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> > index 79713ce075cc..adad0ea61799 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > @@ -37,17 +37,20 @@
> >  #define __dw_pcie_ver_cmp(_pci, _ver, _op) \
> >  	((_pci)->version _op DW_PCIE_VER_ ## _ver)
> > 
> > +#define __dw_pcie_ver_type_cmp(_pci, _type, _op) \
> > +	((_pci)->type _op DW_PCIE_VER_TYPE_ ## _type)
> > +
> >  #define dw_pcie_ver_is(_pci, _ver) __dw_pcie_ver_cmp(_pci, _ver, ==)
> > 
> >  #define dw_pcie_ver_is_ge(_pci, _ver) __dw_pcie_ver_cmp(_pci, _ver, >=)
> > 
> >  #define dw_pcie_ver_type_is(_pci, _ver, _type) \
> >  	(__dw_pcie_ver_cmp(_pci, _ver, ==) && \
> > -	 __dw_pcie_ver_cmp(_pci, TYPE_ ## _type, ==))
> > +	 __dw_pcie_ver_type_cmp(_pci, _type, ==))
> > 
> >  #define dw_pcie_ver_type_is_ge(_pci, _ver, _type) \
> >  	(__dw_pcie_ver_cmp(_pci, _ver, ==) && \
> > -	 __dw_pcie_ver_cmp(_pci, TYPE_ ## _type, >=))
> > +	 __dw_pcie_ver_type_cmp(_pci, _type, >=))
> > 
> >  /* DWC PCIe controller capabilities */
> >  #define DW_PCIE_CAP_REQ_RES		0
> > --
> > 2.40.0
> > 
>