linux-kernel - Re: [PATCH v2] w1: Replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12a57688-6e9a-a21d-41cb-978a274c8b2b@kernel.org>
Date:   Fri, 12 May 2023 12:26:19 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jakob Koschel <jkl820.git@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Evgeniy Polyakov <zbr@...emap.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] w1: Replace usage of found with dedicated list
 iterator variable

On 12/05/2023 12:19, Jakob Koschel wrote:
> How strange, I just checked and my checkpatch doesn't complain.
> 
> I also redownloaded and double checked 
> (b4 am 20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@...il.com).
> 
> What's the exact issue you are seeing?

  ✓ [PATCH v2] w1: Replace usage of found with dedicated list iterator
variable
    + Link:
https://lore.kernel.org/r/20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com
    + Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
  ---
  ✗ No key: ed25519/jkl820.git@...il.com
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1
---
 Base: using specified base-commit eeac8ede17557680855031c6f305ece2378af326
Applying: w1: Replace usage of found with dedicated list iterator variable
[Checking commit]  12b61e664c29 w1: Replace usage of found with
dedicated list iterator variable
[Checkpatch]
CHECK: Alignment should match open parenthesis
#70: FILE: drivers/w1/w1.c:849:
+			if (iter->reg_num.family == id->family &&
+					iter->reg_num.id == id->id &&



Best regards,
Krzysztof