linux-kernel - [PATCH] crypto: sa2ul: change unsafe data size limit to 255 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230512104044.163279-1-j-choudhary@ti.com>
Date:   Fri, 12 May 2023 16:10:44 +0530
From:   Jayesh Choudhary <j-choudhary@...com>
To:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>
CC:     <kristo@...nel.org>, <kamlesh@...com>, <u-kumar1@...com>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <j-choudhary@...com>
Subject: [PATCH] crypto: sa2ul: change unsafe data size limit to 255 bytes

From: Tero Kristo <t-kristo@...com>

256 bytes is quite often used in performance benchmarks and this size
appears to be also working just fine, so mark it as safe so that we do
not fallback to software implementation for this packet size. Otherwise
there is a strange bump up in crypto performance at 256 byte packet size.

Signed-off-by: Tero Kristo <t-kristo@...com>
Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
---
 drivers/crypto/sa2ul.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h
index 92bf97232a29..12c17a68d350 100644
--- a/drivers/crypto/sa2ul.h
+++ b/drivers/crypto/sa2ul.h
@@ -170,7 +170,7 @@ struct sa_tfm_ctx;
  * the following range, so avoid using it.
  */
 #define SA_UNSAFE_DATA_SZ_MIN	240
-#define SA_UNSAFE_DATA_SZ_MAX	256
+#define SA_UNSAFE_DATA_SZ_MAX	255
 
 struct sa_match_data;
 
-- 
2.25.1