linux-kernel - Re: [PATCH v2] hwrng: histb - Move driver to drivers/char/hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZF4b8Iz1CRPHCg4J@gondor.apana.org.au>
Date:   Fri, 12 May 2023 18:58:56 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Yang <mmyangfl@...il.com>
Cc:     linux-crypto@...r.kernel.org, Olivia Mackall <olivia@...enic.com>,
        Weili Qian <qianweili@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jia Jie Ho <jiajie.ho@...rfivetech.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Jenny Zhang <jenny.zhang@...rfivetech.com>,
        William Zhang <william.zhang@...adcom.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwrng: histb - Move driver to
 drivers/char/hw_random/histb-rng.c

On Sat, Apr 22, 2023 at 12:56:49AM +0800, David Yang wrote:
> Move to drivers/char/hw_random since histb-(t)rng does not provide
> cryptography pseudo rng.
> 
> histb-rng is pretty like hisi-rng, but after investigation, we confirm
> there is no RNG_PHY_SEED register on histb-rng so a separate driver is
> needed.
> 
> Still we rename relevant function names to match those in hisi-rng.
> 
> Link: https://lore.kernel.org/r/20230401164448.1393336-1-mmyangfl@gmail.com
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
> v2: drop the dependency on HW_RANDOM
>  drivers/char/hw_random/Kconfig                | 11 +++
>  drivers/char/hw_random/Makefile               |  1 +
>  .../trng-stb.c => char/hw_random/histb-rng.c} | 83 +++++++++----------
>  drivers/crypto/hisilicon/Kconfig              |  7 --
>  drivers/crypto/hisilicon/Makefile             |  2 +-
>  drivers/crypto/hisilicon/trng/Makefile        |  3 -
>  6 files changed, 53 insertions(+), 54 deletions(-)
>  rename drivers/{crypto/hisilicon/trng/trng-stb.c => char/hw_random/histb-rng.c} (53%)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt