linux-kernel - Re: [PATCH] Revert "arm64: dts: zynqmp: Add address-cells property to interrupt controllers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <452a60bc-cb8e-b5de-4317-c107521db7c5@amd.com>
Date:   Fri, 12 May 2023 13:28:00 +0200
From:   Michal Simek <michal.simek@....com>
To:     Michal Simek <michal.simek@....com>, linux-kernel@...r.kernel.org,
        michal.simek@...inx.com, git@...inx.com
Cc:     Harini Katakam <harini.katakam@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Robert Hancock <robert.hancock@...ian.com>,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Tanmay Shah <tanmay.shah@....com>,
        Vishal Sagar <vishal.sagar@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Revert "arm64: dts: zynqmp: Add address-cells property to
 interrupt controllers"



On 5/2/23 15:51, Michal Simek wrote:
> This reverts commit c6badbd2d321c19d4f55ee56b0ef12bb3352feac.
> 
> Long time ago this was discussed with Rob at link below that there is no
> need to add address-cells to gpio and interrupt nodes that's why reverting
> this patch for ZynqMP.
> Also there is no visible DTC warning which was seen in past.
> 
> Link: https://lore.kernel.org/r/91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com
> Signed-off-by: Michal Simek <michal.simek@....com>
> ---
> 
>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 51b8349dcacd..2d564ba7e9e4 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -419,7 +419,6 @@ fpd_dma_chan8: dma-controller@...70000 {
>   
>   		gic: interrupt-controller@...10000 {
>   			compatible = "arm,gic-400";
> -			#address-cells = <0>;
>   			#interrupt-cells = <3>;
>   			reg = <0x0 0xf9010000 0x0 0x10000>,
>   			      <0x0 0xf9020000 0x0 0x20000>,
> @@ -633,7 +632,6 @@ gem3: ethernet@...e0000 {
>   		gpio: gpio@...a0000 {
>   			compatible = "xlnx,zynqmp-gpio-1.0";
>   			status = "disabled";
> -			#address-cells = <0>;
>   			#gpio-cells = <0x2>;
>   			gpio-controller;
>   			interrupt-parent = <&gic>;

Applied.
M