linux-kernel - Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 May 2023 13:27:55 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Linux SPDX Licenses <linux-spdx@...r.kernel.org>,
        Linux DRI Development <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Networking <netdev@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Staging Drivers <linux-staging@...ts.linux.dev>,
        Linux Watchdog Devices <linux-watchdog@...r.kernel.org>,
        Linux Kernel Actions <linux-actions@...ts.infradead.org>,
        Diederik de Haas <didi.debian@...ow.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        David Airlie <airlied@...hat.com>,
        Karsten Keil <isdn@...ux-pingi.de>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Sam Creasey <sammy@...my.net>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>, Jan Kara <jack@...e.com>,
        Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <mani@...nel.org>,
        "David A . Hinds" <dahinds@...rs.sourceforge.net>,
        Donald Becker <becker@...ld.com>,
        Peter De Schrijver <p2@...d.be>,
        Topi Kanerva <topi@...anna.oulu.fi>,
        Alain Malek <Alain.Malek@...ogen.com>,
        Bruce Abbott <bhabbott@...b.co.nz>,
        Alan Cox <alan@...ux.intel.com>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate
 with SPDX identifier

Hi Bagas,

On Fri, May 12, 2023 at 12:08 PM Bagas Sanjaya <bagasdotme@...il.com> wrote:
> Replace GPL boilerplate notice on remaining files with appropriate SPDX
> tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+.
>
> Cc: David A. Hinds <dahinds@...rs.sourceforge.net>
> Cc: Donald Becker <becker@...ld.com>
> Cc: Peter De Schrijver <p2@...d.be>
> Cc: Topi Kanerva <topi@...anna.oulu.fi>
> Cc: Alain Malek <Alain.Malek@...ogen.com>
> Cc: Bruce Abbott <bhabbott@...b.co.nz>
> Cc: Alan Cox <alan@...ux.intel.com>
> Acked-by: Greg Ungerer <gerg@...ux-m68k.org>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Thanks for your patch!

> --- a/drivers/net/ethernet/8390/apne.c
> +++ b/drivers/net/ethernet/8390/apne.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-1.0+

As per the removed lines below, this should be GPL-2.0-only.

>  /*
>   * Amiga Linux/68k 8390 based PCMCIA Ethernet Driver for the Amiga 1200
>   *
> @@ -19,12 +20,6 @@
>   *
>   * ----------------------------------------------------------------------------
>   *
> - * This file is subject to the terms and conditions of the GNU General Public
> - * License.  See the file COPYING in the main directory of the Linux
> - * distribution for more details.
> - *
> - * ----------------------------------------------------------------------------
> - *
>   */
>
>

> --- a/drivers/net/ethernet/8390/hydra.c
> +++ b/drivers/net/ethernet/8390/hydra.c
> @@ -1,10 +1,8 @@
> +// SPDX-License-Identifier: GPL-1.0+

Likewise.

> +
>  /* New Hydra driver using generic 8390 core */
>  /* Based on old hydra driver by Topi Kanerva (topi@...anna.oulu.fi) */
>
> -/* This file is subject to the terms and conditions of the GNU General      */
> -/* Public License.  See the file COPYING in the main directory of the       */
> -/* Linux distribution for more details.                                     */
> -
>  /* Peter De Schrijver (p2@...d.be) */
>  /* Oldenburg 2000 */
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds