linux-kernel - Re: [PATCH v2] soc: qcom: Rename ice to qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50f9263f-eb29-acc8-9fe4-c02480d6dfb6@quicinc.com>
Date:   Fri, 12 May 2023 18:09:34 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Abel Vesa <abel.vesa@...aro.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Biggers <ebiggers@...nel.org>,
        <manivannan.sadhasivam@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v2] soc: qcom: Rename ice to qcom_ice to avoid module name
 conflict



On 5/12/2023 6:06 PM, Abel Vesa wrote:
> The following error was reported when building x86_64 allmodconfig:
> 
> error: the following would cause module name conflict:
>    drivers/soc/qcom/ice.ko
>    drivers/net/ethernet/intel/ice/ice.ko
> 
> Seems the 'ice' module name is already used by some Intel ethernet
> driver, so lets rename the Qualcomm Inline Crypto Engine (ICE) from
> 'ice' to 'qcom_ice' to avoid any kind of errors/confusions.
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>

Acked-by: Mukesh Ojha <quic_mojha@...cinc.com>

-- Mukesh
> ---
> 
> Changes since v1:
>   * changed filename from qcom-ice.c to qcom_ice.c (with underscore)
>     to be in line with other Qcom SoC drivers.
> 
>   drivers/soc/qcom/Makefile              | 2 +-
>   drivers/soc/qcom/{ice.c => qcom_ice.c} | 0
>   2 files changed, 1 insertion(+), 1 deletion(-)
>   rename drivers/soc/qcom/{ice.c => qcom_ice.c} (100%)
> 
> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
> index 0f43a88b4894..cacf3113ec3c 100644
> --- a/drivers/soc/qcom/Makefile
> +++ b/drivers/soc/qcom/Makefile
> @@ -32,4 +32,4 @@ obj-$(CONFIG_QCOM_RPMHPD) += rpmhpd.o
>   obj-$(CONFIG_QCOM_RPMPD) += rpmpd.o
>   obj-$(CONFIG_QCOM_KRYO_L2_ACCESSORS) +=	kryo-l2-accessors.o
>   obj-$(CONFIG_QCOM_ICC_BWMON)	+= icc-bwmon.o
> -obj-$(CONFIG_QCOM_INLINE_CRYPTO_ENGINE)	+= ice.o
> +obj-$(CONFIG_QCOM_INLINE_CRYPTO_ENGINE)	+= qcom_ice.o
> diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/qcom_ice.c
> similarity index 100%
> rename from drivers/soc/qcom/ice.c
> rename to drivers/soc/qcom/qcom_ice.c