linux-kernel - Re: [PATCH 5/5] s390/uv: Update query for secret-UVCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b826b914-a3dc-488d-b4d8-23dbfee29e58@linux.ibm.com>
Date:   Fri, 12 May 2023 15:27:52 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     Heiko Carstens <hca@...ux.ibm.com>,
        Steffen Eiden <seiden@...ux.ibm.com>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Viktor Mihajlovski <mihajlov@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Nico Boehr <nrb@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Hendrik Brueckner <brueckner@...ux.ibm.com>
Subject: Re: [PATCH 5/5] s390/uv: Update query for secret-UVCs

On 5/12/23 14:53, Heiko Carstens wrote:
> On Fri, May 12, 2023 at 11:31:53AM +0200, Steffen Eiden wrote:
>> Update the query struct such that secret-UVC related
>> information can be parsed.
>> Add sysfs files for these new values.
>>
>> Signed-off-by: Steffen Eiden <seiden@...ux.ibm.com>
>> ---
>>   arch/s390/boot/uv.c        |  4 ++++
>>   arch/s390/include/asm/uv.h | 11 ++++++++++-
>>   arch/s390/kernel/uv.c      | 40 ++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 54 insertions(+), 1 deletion(-)
> ...
>> +static ssize_t uv_query_supp_add_secret_req_ver(struct kobject *kobj,
>> +						struct kobj_attribute *attr, char *page)
>> +{
>> +	return scnprintf(page, PAGE_SIZE, "%lx\n", uv_info.supp_add_secret_req_ver);
>> +}
> 
> FWIW, another minor thing: all of these should be sysfs_emit() instead.

Do you want us to move all of them to sysfs_emit() eventually or should 
we keep the scnprintfs() which are already in uv.c ?