linux-kernel - Re: [PATCH 1/4] riscv: vmlinux-xip.lds.S: remove .alternative section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230512-lunar-overbook-e34b468dda65@wendy>
Date:   Fri, 12 May 2023 14:51:56 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Jisheng Zhang <jszhang@...nel.org>
CC:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Arnd Bergmann <arnd@...db.de>,
        <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-arch@...r.kernel.org>
Subject: Re: [PATCH 1/4] riscv: vmlinux-xip.lds.S: remove .alternative section

On Thu, May 11, 2023 at 10:12:08PM +0800, Jisheng Zhang wrote:
> ALTERNATIVE mechanism can't work on XIP, and this is also reflected by
> below Kconfig dependency:
> 
> RISCV_ALTERNATIVE
> 	...
> 	depends on !XIP_KERNEL
> 	...
> 
> So there's no .alternative section at all for XIP case, remove it.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Just to note, this series doesn't apply on top of -rc1 - what is the
base that you used?

Cheers,
Conor.

> ---
>  arch/riscv/kernel/vmlinux-xip.lds.S | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/riscv/kernel/vmlinux-xip.lds.S b/arch/riscv/kernel/vmlinux-xip.lds.S
> index eab9edc3b631..50767647fbc6 100644
> --- a/arch/riscv/kernel/vmlinux-xip.lds.S
> +++ b/arch/riscv/kernel/vmlinux-xip.lds.S
> @@ -98,12 +98,6 @@ SECTIONS
>  		__soc_builtin_dtb_table_end = .;
>  	}
>  
> -	. = ALIGN(8);
> -	.alternative : {
> -		__alt_start = .;
> -		*(.alternative)
> -		__alt_end = .;
> -	}
>  	__init_end = .;
>  
>  	. = ALIGN(16);
> -- 
> 2.40.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)