linux-kernel - Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b382277-e992-39a0-a4ba-c3fd88bfc41e@linaro.org>
Date:   Fri, 12 May 2023 18:18:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     David Rau <David.Rau.opensource@...renesas.com>, broonie@...nel.org
Cc:     support.opensource@...semi.com, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity
 selection

On 12/05/2023 10:10, David Rau wrote:
> DA7219 can support 2 kinds of insertion detection polarity
> - Default polarity (Low)
> - Inverted polarity (High)
> 
> This patch adds support for selecting insertion detection
> polarity to the DT binding.
> 
> Signed-off-by: David Rau <David.Rau.opensource@...renesas.com>
> ---
>  .../devicetree/bindings/sound/da7219.txt      |  3 ++

Bindings are always separate patches.

Consider also converting them to DT schema first.

>  include/sound/da7219-aad.h                    |  6 ++++
>  sound/soc/codecs/da7219-aad.c                 | 34 +++++++++++++++++++
>  3 files changed, 43 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/da7219.txt b/Documentation/devicetree/bindings/sound/da7219.txt
> index add1caf26ac2..357d1f61de1d 100644
> --- a/Documentation/devicetree/bindings/sound/da7219.txt
> +++ b/Documentation/devicetree/bindings/sound/da7219.txt



Best regards,
Krzysztof