linux-kernel - Re: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after kfree_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d508096-300c-4d16-9c39-18598d00b500@paulmck-laptop>
Date:   Fri, 12 May 2023 09:40:05 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...a.com,
        rostedt@...dmis.org
Subject: Re: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after
 kfree_scale_cleanup()

On Thu, May 11, 2023 at 09:15:17PM -0700, Joel Fernandes wrote:
> 
> 
> > On May 11, 2023, at 8:20 PM, Zhuo, Qiuxu <qiuxu.zhuo@...el.com> wrote:
> > 
> > 
> >> 
> >> From: Paul E. McKenney <paulmck@...nel.org>
> >> ...
> >>>> I wish diff was better at showing what really changed. The meld tool
> >>>> can help but its gui...
> >>>> 
> >>>> Should I run meld later (I'm out at a conference so no access to
> >>>> meld-capable
> >>>> machines) or are we sufficiently confident that the lines were moved
> >>>> as-is ? :)
> >>>> 
> >>> 
> >>> Thank you, Joel for this concern. Good to know the meld diff GUI tool.
> >>> I just run the command below and confirmed that the lines were moved
> >>> as-is: rcu_scale_{cleanup,shutdown}() follows kfree_scale_cleanup().
> >>> You may double check it ;-).
> >>> 
> >>>      meld --diff ./rcuscale.c.before ./rcuscale.c.after
> >> 
> >> Nice, thank you both!
> >> 
> >> Another option is to check out the commit corresponding to this patch, then
> >> do "git blame -M kernel/rcu/rcuscale.c".  Given a move-only commit, there
> >> should be no line tagged with this commit's SHA-1.
> > 
> > Just had a good experiment with the "git blame -M" option: 
> > - Used this option to prove a move-only commit quickly (no line tagged with that commit) (the fastest method to me). 
> > - Then just only needed to quickly check the positions of the moved code chunk by myself (easy).  
> > 
> > Thank you, Paul for sharing this. It's very useful to me. 
> 
> Looks good to me as well and thank you both for sharing the tips.

Here is one way to script this, where "SHA" identifies the commit to
be checked and PATHS the affected pathnames:

	git checkout SHA^
	git show SHA | git apply -
	git blame -M PATHS | grep '^0* '

If there is no output, there were no non-move changes.  

Or just do the "git blame -M PATHS | grep '^0* '" before doing the
checking.

And yes, you can derive PATHS using "git status" if you want.  ;-)

							Thanx, Paul