linux-kernel - Re: [PATCH 2/3] PCIE: j721e: Add support to build pci-j721e as a kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZF5tmV+cXc/qwQAU@bhelgaas>
Date:   Fri, 12 May 2023 11:47:21 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Achal Verma <a-verma1@...com>
Cc:     Tom Joseph <tjoseph@...ence.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczy_ski <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Arnd Bergmann <arnd@...db.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        "N_colas F . R . A . Prado" <nfraprado@...labora.com>,
        Mark Brown <broonie@...nel.org>,
        Rafa_ Mi_ecki <rafal@...ecki.pl>,
        Vignesh Raghavendra <vigneshr@...com>,
        Nishanth Menon <nm@...com>, Milind Parab <mparab@...ence.com>,
        Swapnil Kashinath Jakhade <sjakhade@...ence.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/3] PCIE: j721e: Add support to build pci-j721e as a
 kernel module

Follow previous subject line style (specifically, "PCI" not "PCIE"):

  053ca37c87af ("PCI: j721e: Initialize pcie->cdns_pcie before using it")
  19e863828acf ("PCI: j721e: Drop redundant struct device *")
  72de208f2bda ("PCI: j721e: Drop pointless of_device_get_match_data() cast")
  496bb18483cc ("PCI: j721e: Fix j721e_pcie_probe() error path")
  c8a375a8e15a ("PCI: j721e: Add PCIe support for AM64")
  f1de58802f0f ("PCI: j721e: Add PCIe support for J7200")

On Fri, May 12, 2023 at 12:35:09PM +0530, Achal Verma wrote:
> pci-j721e driver can be build as a in-built kernel driver only, which is not required as it
> is not used during boot time in most cases. This change add support to build pci-j721e as a
> kernel loadable module.
> J721e PCIe controller can work in both host mode and end-point mode.
> In order to enable host mode driver and endpoint driver to be built independently either
> as built-in or kernel module, the pcie-j721e.c driver is refactored into following components:
> 
> 1) pci-j721e-host.c : Driver used when PCIe controller has to be initialized in host mode.
> 2) pci-j721e-ep.c : Driver used when PCIe controller has to be initialized in endpoint mode.
> 3) pci-j721e.c : contains common code required in both modes.

Wrap all to fit in 75 columns, add blank lines between paragraphs.

Bjorn