linux-kernel - Re: [PATCH] net: marvell: fix error checking for debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZF9fj9SEQbBLNgWB@shell.armlinux.org.uk>
Date:   Sat, 13 May 2023 10:59:43 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     SikkiLadho <mushi.shar@...il.com>
Cc:     mw@...ihalf.com, linux-kernel@...r.kernel.org,
        Ivan Orlov <ivan.orlov0322@...il.com>
Subject: Re: [PATCH] net: marvell: fix error checking for debugfs

On Sat, May 13, 2023 at 06:46:28AM +0500, SikkiLadho wrote:
> This commit fixes error checking in by using IS_ERR inline function to
> check for errors.
> 
> Suggested-by: Ivan Orlov <ivan.orlov0322@...il.com>
> Signed-off-by: SikkiLadho <mushi.shar@...il.com>

The modern wisdom for debugfs is not to check for any errors, so if
we're going to touch this, that's the route that any patch should be
taking.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!