linux-kernel - Re: [PATCH v3 0/2] Add support for the ICM 20600 IMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230513185821.122ac3a4@jic23-huawei>
Date:   Sat, 13 May 2023 18:58:21 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Hermes Zhang <chenhuiz@...s.com>
Cc:     <krzysztof.kozlowski+dt@...aro.org>, <robh+dt@...nel.org>,
        <jmaneyrol@...ensense.com>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...s.com>
Subject: Re: [PATCH v3 0/2] Add support for the ICM 20600 IMU

On Sat, 6 May 2023 17:37:17 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Fri, 5 May 2023 13:48:51 +0800
> Hermes Zhang <chenhuiz@...s.com> wrote:
> 
> > The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a
> > 3-axis gyroscope and an 3-axis accelerometer. It is very similar to the
> > ICM20602 imu which is already supported by the mpu6050 driver. The main
> > difference is that the ICM-20600 has a different WHOAMI value.
> > 
> > Notes:
> >     v2: require specifying "invensense,icm20602" as a fallback compatible
> >         in the binding, as suggested
> >     v3: reorder "invensense,icm20602" entry before icm20608 and add
> >         Reviewed-by tag from Krzysztof  
> 
> Looks good to me.  I want to leave a little more time for Jean-Baptiste to take
> a look.  If it looks like I've forgotten this in 2 weeks, feel free to give me
> a poke.

Series applied to the togreg branch of iio.git and initially pushed out as
testing for 0-day to take a look and see if we missed anything.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> 
> > 
> > Hermes Zhang (2):
> >   dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
> >   iio: imu: mpu6050: Add support for the ICM 20600 IMU
> > 
> >  .../bindings/iio/imu/invensense,mpu6050.yaml           |  3 +++
> >  drivers/iio/imu/inv_mpu6050/Kconfig                    |  4 ++--
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c             | 10 ++++++++++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c              |  6 ++++++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h              |  2 ++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c              |  5 +++++
> >  6 files changed, 28 insertions(+), 2 deletions(-)
> >   
>