linux-kernel - Re: [PATCH v4 0/3] Add the Renesas X9250 potentiometers IIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230513193547.5e2bcff3@jic23-huawei>
Date:   Sat, 13 May 2023 19:35:47 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Herve Codina <herve.codina@...tlin.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 0/3] Add the Renesas X9250 potentiometers IIO support

On Tue,  9 May 2023 18:08:49 +0200
Herve Codina <herve.codina@...tlin.com> wrote:

> Hi,
> 
> The Renesas X9250 integrated four digitally controlled potentiometers.
> On each potentiometer, the X9250T has a 100 kOhms total resistance and
> the X9250U has a 50 kOhms total resistance.
> 
> Compare to the previous iteration
>   https://lore.kernel.org/linux-kernel/20230421085245.302169-1-herve.codina@bootlin.com/
> This v4 series updates the binding, introduced the power-supply
> regulators and the write-protect gpio, uses spi_write_then_read(),
> removes spi_get_device_id(spi)->name, removes spi_set_drvdata() call.
> 
> Best regards,
> Herve Codina

Series applied to the togreg branch of iio.git with one tweak as per reply to patch 2.

Thanks,

Jonathan

> 
> Changes v3 -> v4
>   - Patch 1
>     Remove iio.yaml.
>     Add 'vcc-supply', 'avp-supply' and 'avn-supply'.
>     Add 'wp-gpios'
> 
>   - Patch 2
>     Get and enable the regulators.
>     Manage the write-protect gpio.
>     Use spi_write_then_read().
>     Remove the unneeded spi_setup() call.
>     Get name from field added in struct x9250_cfg instead of
>     spi_get_device_id(spi)->name.
> 
>   - Patch 3
>     No changes
> 
> Changes v2 -> v3
>   - Patch 1
>     Remove the reg property description
>     Use 'potentiometer' for the node name in the example.
> 
>   - Patch 2 and 3
>     No changes
> 
> Changes v1 -> v2
>   - Patch 1
>     No changes
> 
>   - Patch 2
>     Use a define for the 0x50 value used multiple times.
> 
>   - Patch 3
>     No changes
> 
> Herve Codina (3):
>   dt-bindings: iio: potentiometer: Add the Renesas X9250 potentiometers
>   iio: potentiometer: Add support for the Renesas X9250 potentiometers
>   MAINTAINERS: add the Renesas X9250 driver entry
> 
>  .../iio/potentiometer/renesas,x9250.yaml      |  78 ++++++
>  MAINTAINERS                                   |   7 +
>  drivers/iio/potentiometer/Kconfig             |  10 +
>  drivers/iio/potentiometer/Makefile            |   1 +
>  drivers/iio/potentiometer/x9250.c             | 223 ++++++++++++++++++
>  5 files changed, 319 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/renesas,x9250.yaml
>  create mode 100644 drivers/iio/potentiometer/x9250.c
>