linux-kernel - RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB48384EE068A9B8247C69E3C6887A9@AM6PR04MB4838.eurprd04.prod.outlook.com>
Date:   Sat, 13 May 2023 04:23:50 +0000
From:   Frank Li <frank.li@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Peter Chen <peter.chen@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        "pawell@...ence.com" <pawell@...ence.com>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8: fix USB 3.0 Gadget
 Failure in QM & QXPB0 at super speed


> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > index b32c2e199c160..030c273c8be40 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
> > @@ -171,6 +171,7 @@ usbotg3_cdns3: usb@...20000 {
> >                       interrupt-names = "host", "peripheral", "otg", "wakeup";
> >                       phys = <&usb3_phy>;
> >                       phy-names = "cdns3,usb3-phy";
> > +                     cdns,on-chip-buff-size = /bits/ 16 <18>;
> 
> The property is defined as uint32 in the bindings.  Not sure why we
> need to enforce 16-bits here.

Driver code use 16bit, if use 32bit here, it will be zero. 
I have not checked bindings doc. Next version will fix binding doc.

Frank

> 
> Shawn
> 
> >                       status = "disabled";
> >               };
> >       };
> > --
> > 2.34.1
> >