linux-kernel - Re: [PATCH] ext4: check iomap type only if ext4_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 13 May 2023 00:59:30 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     linux-ext4@...r.kernel.org, Baokun Li <libaokun1@...wei.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca,
        jack@...e.cz, ritesh.list@...il.com, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com, yangerkun@...wei.com, yukuai3@...wei.com,
        syzbot+08106c4b7d60702dbc14@...kaller.appspotmail.com
Subject: Re: [PATCH] ext4: check iomap type only if ext4_iomap_begin() does not fail


On Fri, 05 May 2023 21:24:29 +0800, Baokun Li wrote:
> When ext4_iomap_overwrite_begin() calls ext4_iomap_begin() map blocks may
> fail for some reason (e.g. memory allocation failure, bare disk write), and
> later because "iomap->type ! = IOMAP_MAPPED" triggers WARN_ON(). When ext4
> iomap_begin() returns an error, it is normal that the type of iomap->type
> may not match the expectation. Therefore, we only determine if iomap->type
> is as expected when ext4_iomap_begin() is executed successfully.
> 
> [...]

Applied, thanks!

[1/1] ext4: check iomap type only if ext4_iomap_begin() does not fail
      commit: 705c514635a4b6fd0ee321bcf1a9bd75c3629b71

Best regards,
-- 
Theodore Ts'o <tytso@....edu>