linux-kernel - Re: [PATCH] power: supply: rt9467: Fix passing zero to 'dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230514225458.nngl45joh4crunal@mercury.elektranox.org>
Date:   Mon, 15 May 2023 00:54:58 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     ChiaEn Wu <chiaen_wu@...htek.com>
Cc:     dan.carpenter@...aro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, peterwu.pub@...il.com,
        cy_huang@...htek.com
Subject: Re: [PATCH] power: supply: rt9467: Fix passing zero to
 'dev_err_probe'

Hi,

On Fri, May 12, 2023 at 01:44:23PM +0800, ChiaEn Wu wrote:
> Fix passing zero to 'dev_err_probe()' in 'rt9467_request_interrupt()'
> 
> Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/r/202305111228.bHLWU6bq-lkp@intel.com/
> Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> ---

Thanks, queued to my fixes branch.

-- Sebastian

>  drivers/power/supply/rt9467-charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c
> index 73f744a..ea33693 100644
> --- a/drivers/power/supply/rt9467-charger.c
> +++ b/drivers/power/supply/rt9467-charger.c
> @@ -1023,7 +1023,7 @@ static int rt9467_request_interrupt(struct rt9467_chg_data *data)
>  	for (i = 0; i < num_chg_irqs; i++) {
>  		virq = regmap_irq_get_virq(data->irq_chip_data, chg_irqs[i].hwirq);
>  		if (virq <= 0)
> -			return dev_err_probe(dev, virq, "Failed to get (%s) irq\n",
> +			return dev_err_probe(dev, -EINVAL, "Failed to get (%s) irq\n",
>  					     chg_irqs[i].name);
>  
>  		ret = devm_request_threaded_irq(dev, virq, NULL, chg_irqs[i].handler,
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)