linux-kernel - Re: [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202305141608.tB1ES6sg-lkp@intel.com>
Date:   Sun, 14 May 2023 17:44:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rudi Heitbaum <rudi@...tbaum.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, wens@...e.org, jernej.skrabec@...il.com,
        samuel@...lland.org, marcel@...tmann.org, johan.hedberg@...il.com,
        luiz.dentz@...il.com, anarsoul@...il.com, alistair@...stair23.me
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-bluetooth@...r.kernel.org, Rudi Heitbaum <rudi@...tbaum.com>
Subject: Re: [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART

Hi Rudi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bb7c241fae6228e89c0286ffd6f249b3b0dea225]

url:    https://github.com/intel-lab-lkp/linux/commits/Rudi-Heitbaum/dt-bindings-net-realtek-bluetooth-Add-RTL8822BS/20230514-155000
base:   bb7c241fae6228e89c0286ffd6f249b3b0dea225
patch link:    https://lore.kernel.org/r/20230514074731.70614-3-rudi%40heitbaum.com
patch subject: [PATCH 2/3] Bluetooth: btrtl: Add support for RTL8822BS UART
config: csky-randconfig-r035-20230514
compiler: csky-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2f68c37a4fd8f66ba45a8ff74d845954644401e0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Rudi-Heitbaum/dt-bindings-net-realtek-bluetooth-Add-RTL8822BS/20230514-155000
        git checkout 2f68c37a4fd8f66ba45a8ff74d845954644401e0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash drivers/bluetooth/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305141608.tB1ES6sg-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/bluetooth/btrtl.c: In function 'btrtl_set_quirks':
>> drivers/bluetooth/btrtl.c:1194:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
    1194 |                 set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, &hdev->quirks);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/bluetooth/btrtl.c:1195:9: note: here
    1195 |         default:
         |         ^~~~~~~


vim +1194 drivers/bluetooth/btrtl.c

  1164	
  1165	void btrtl_set_quirks(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev)
  1166	{
  1167		/* Enable controller to do both LE scan and BR/EDR inquiry
  1168		 * simultaneously.
  1169		 */
  1170		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
  1171	
  1172		/* Enable central-peripheral role (able to create new connections with
  1173		 * an existing connection in slave role).
  1174		 */
  1175		/* Enable WBS supported for the specific Realtek devices. */
  1176		switch (btrtl_dev->project_id) {
  1177		case CHIP_ID_8822C:
  1178		case CHIP_ID_8852A:
  1179		case CHIP_ID_8852B:
  1180		case CHIP_ID_8852C:
  1181		case CHIP_ID_8851B:
  1182			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
  1183			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
  1184	
  1185			/* RTL8852C needs to transmit mSBC data continuously without
  1186			 * the zero length of USB packets for the ALT 6 supported chips
  1187			 */
  1188			if (btrtl_dev->project_id == CHIP_ID_8852C)
  1189				btrealtek_set_flag(hdev, REALTEK_ALT6_CONTINUOUS_TX_CHIP);
  1190	
  1191			hci_set_aosp_capable(hdev);
  1192			break;
  1193		case CHIP_ID_8822B:
> 1194			set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2, &hdev->quirks);
  1195		default:
  1196			rtl_dev_dbg(hdev, "Central-peripheral role not enabled.");
  1197			rtl_dev_dbg(hdev, "WBS supported not enabled.");
  1198			break;
  1199		}
  1200	
  1201		if (!btrtl_dev->ic_info)
  1202			return;
  1203	
  1204		switch (btrtl_dev->ic_info->lmp_subver) {
  1205		case RTL_ROM_LMP_8703B:
  1206			/* 8723CS reports two pages for local ext features,
  1207			 * but it doesn't support any features from page 2 -
  1208			 * it either responds with garbage or with error status
  1209			 */
  1210			set_bit(HCI_QUIRK_BROKEN_LOCAL_EXT_FEATURES_PAGE_2,
  1211				&hdev->quirks);
  1212			break;
  1213		default:
  1214			break;
  1215		}
  1216	}
  1217	EXPORT_SYMBOL_GPL(btrtl_set_quirks);
  1218	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (177176 bytes)