linux-kernel - Re: [PATCH] arm64: dts: imx8mp: Fix video clock parents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230515031601.GD767028@dragon>
Date:   Mon, 15 May 2023 11:16:01 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Adam Ford <aford173@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, marex@...x.de,
        aford@...conembedded.com, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp: Fix video clock parents

On Thu, May 11, 2023 at 08:04:23PM -0500, Adam Ford wrote:
> There are a few clocks whose parents are set in mipi_dsi
> and lcdif nodes, but these clocks are used by the media_blk_ctrl
> power domain.  This may cause an issue when re-parenting, because
> the media_blk_ctrl may start the clocks before the reparent is
> done resulting in a disp_pixel clock having the wrong parent and
> rate.
> 
> Fix this by moving the assigned-clock-parents and rates to the
> media_blk_ctrl node to configure these clocks before they are enabled.
> 
> After this patch, both disp1_pix_root and dixp2_pix_root clock
> become children of the video_pll1.
> 
> video_pll1_ref_sel           24000000
>   video_pll1               1039500000
>     video_pll1_bypass        1039500000
>       video_pll1_out           1039500000
>         media_disp2_pix          1039500000
>           media_disp2_pix_root_clk   1039500000
>         media_disp1_pix          1039500000
>           media_disp1_pix_root_clk   1039500000
> 
> Fixes: eda09fe149df ("arm64: dts: imx8mp: Add display pipeline components")
> Signed-off-by: Adam Ford <aford173@...il.com>

Applied, thanks!