linux-kernel - Re: [PATCH v7 4/4] crypto: starfive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 May 2023 11:27:35 +0800
From:   Jia Jie Ho <jiajie.ho@...rfivetech.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Conor Dooley <conor@...nel.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        <linux-crypto@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v7 4/4] crypto: starfive - Add hash and HMAC support

On 12/5/2023 6:55 pm, Herbert Xu wrote:
> On Thu, May 04, 2023 at 03:34:00PM +0800, Jia Jie Ho wrote:
>>
>> +	writel(~STARFIVE_IE_MASK_HASH_DONE, cryp->base + STARFIVE_IE_MASK_OFFSET);
>> +	writel(csr.v, cryp->base + STARFIVE_HASH_SHACSR);
> 
> With compile testing I get
> 
> ../drivers/crypto/starfive/jh7110-hash.c: In function ‘starfive_hash_start’:
> ../drivers/crypto/starfive/jh7110-hash.c:110:9: warning: conversion from ‘long unsigned int’ to ‘unsigned int’ changes value from ‘18446744073709551611’ to ‘4294967291’ [-Woverflow]
> 

Hi Herbert,
I've added COMPILE_TEST in the Kconfig, then ran make W=1, sparse and smatch.
However it did not produce the error message.

+config CRYPTO_DEV_JH7110
+       tristate "StarFive JH7110 cryptographic engine driver"
+       depends on SOC_STARFIVE || COMPILE_TEST
+       select CRYPTO_ENGINE

Symbol: COMPILE_TEST [=y]
Type  : bool
Defined at init/Kconfig:142

make C=2 drivers/crypto/
make W=1 drivers/crypto/
~/smatch/smatch_scripts/kchecker drivers/crypto/

Am I missing something?

Thanks,
Jia Jie