linux-kernel - Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69538f77-ff08-c3ce-3d4a-9f7250ee2505@quicinc.com>
Date:   Mon, 15 May 2023 11:20:02 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>
CC:     <dri-devel@...ts.freedesktop.org>, <robdclark@...il.com>,
        <sean@...rly.run>, <swboyd@...omium.org>, <dianders@...omium.org>,
        <vkoul@...nel.org>, <daniel@...ll.ch>, <airlied@...il.com>,
        <agross@...nel.org>, <dmitry.baryshkov@...aro.org>,
        <andersson@...nel.org>, <quic_jesszhan@...cinc.com>,
        <quic_sbillaka@...cinc.com>, <freedreno@...ts.freedesktop.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets
 in catalog



On 5/14/2023 2:39 PM, Marijn Suijten wrote:
> DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while
> the series is clearly aimed at 1.1...).  This was done for the DSC 1.2
> HW block patch after all.
> 
> in catalog -> to catalog
> 
> But it's just two platforms, you can fit MSM8998 and SC8180X in the
> title.
> 
> On 2023-05-12 11:00:16, Kuogee Hsieh wrote:
>>
>> From: Abhinav Kumar <quic_abhinavk@...cinc.com>
>>
>> There are some platforms has DSC blocks but it is not declared at catalog.
> 
> Some platforms have DSC blocks which have not yet been declared in the
> catalog.*
> 
>> For completeness, this patch adds DSC blocks for platforms which missed
>> them.
> 
> Drop "this patch":
> 
>      Complete DSC 1.1 support for all platforms by adding the missing
>      blocks to MSM8998 and SC8180X.
> 
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |  7 +++++++
>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 11 +++++++++++
> 
> How about SC7180, and any other DPU 6.x revision?
> 

Will let kuogee respond to the other nits. There is no DSC in sc7180 / 
sm6115 / qcm2290. So this patch is complete.

> Rest of the patch looks good and complete.
> 
> - Marijn
> 
>>   2 files changed, 18 insertions(+)
>>