linux-kernel - Re: [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93b20305-72e2-4916-aa72-7595a776917f@lunn.ch>
Date:   Tue, 16 May 2023 00:37:46 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marco Migliore <m.migliore@...sse.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command
 offset

On Tue, May 16, 2023 at 12:09:18AM +0200, Marco Migliore wrote:
> According to datasheet, the command opcode must be specified
> into bits [14:12] of the Extended Port Control register (EPC).
> 
> Signed-off-by: Marco Migliore <m.migliore@...sse.com>

Hi Marco

Please read the netdev FAQ:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Please add a Fixes: tag, to indicate the patch which introduced the
problem and needs fixing. Also, set the subject to indicate this is
for the net tree.

Thanks
	Andrew