linux-kernel - Re: [PATCH] power: supply: mt6360: add a check of devm_work_autocancel in mt6360_charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 00:49:36 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     void0red <void0red@...il.com>
Cc:     angelogioacchino.delregno@...labora.com, matthias.bgg@...il.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] power: supply: mt6360: add a check of
 devm_work_autocancel in mt6360_charger_probe

Hi,

On Mon, Feb 27, 2023 at 11:14:10AM +0800, void0red wrote:
> From: Kang Chen <void0red@...il.com>
> 
> devm_work_autocancel may fails, add a check and return early.
> 
> Signed-off-by: Kang Chen <void0red@...il.com>
> ---

Thanks, queued to my fixes branch with Fixes tag added.

-- Sebastian

>  drivers/power/supply/mt6360_charger.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supply/mt6360_charger.c
> index 92e48e3a4..1305cba61 100644
> --- a/drivers/power/supply/mt6360_charger.c
> +++ b/drivers/power/supply/mt6360_charger.c
> @@ -796,7 +796,9 @@ static int mt6360_charger_probe(struct platform_device *pdev)
>  	mci->vinovp = 6500000;
>  	mutex_init(&mci->chgdet_lock);
>  	platform_set_drvdata(pdev, mci);
> -	devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work);
> +	ret = devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work);
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret, "Failed to set delayed work\n");
>  
>  	ret = device_property_read_u32(&pdev->dev, "richtek,vinovp-microvolt", &mci->vinovp);
>  	if (ret)
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)