linux-kernel - Re: [PATCH 0/2] Add rs485 support to uartps driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55da12c2-dd4f-ebfa-c747-f12df6f7887d@amd.com>
Date:   Mon, 15 May 2023 08:35:05 +0200
From:   Michal Simek <michal.simek@....com>
To:     m.brock@...mierlo.com,
        "Guntupalli, Manikanta" <manikanta.guntupalli@....com>
Cc:     gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, michal.simek@...inx.com,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, jirislaby@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        "git (AMD-Xilinx)" <git@....com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
        "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>,
        "Goud, Srinivas" <srinivas.goud@....com>, manion05gk@...il.com
Subject: Re: [PATCH 0/2] Add rs485 support to uartps driver



On 5/14/23 13:01, m.brock@...mierlo.com wrote:
> Guntupalli, Manikanta schreef op 2023-05-10 18:26:
>> Hi Maarten,
>>
>>> -----Original Message-----
>>> From: m.brock@...mierlo.com <m.brock@...mierlo.com>
>>> Sent: Thursday, May 4, 2023 5:52 PM
>>> To: Guntupalli, Manikanta <manikanta.guntupalli@....com>
>>> Cc: gregkh@...uxfoundation.org; robh+dt@...nel.org;
>>> krzysztof.kozlowski+dt@...aro.org; michal.simek@...inx.com; linux-
>>> serial@...r.kernel.org; devicetree@...r.kernel.org; linux-
>>> kernel@...r.kernel.org; jirislaby@...nel.org; linux-arm-
>>> kernel@...ts.infradead.org; Simek, Michal <michal.simek@....com>; git
>>> (AMD-Xilinx) <git@....com>; Pandey, Radhey Shyam
>>> <radhey.shyam.pandey@....com>; Datta, Shubhrajyoti
>>> <shubhrajyoti.datta@....com>; Goud, Srinivas <srinivas.goud@....com>;
>>> manion05gk@...il.com
>>> Subject: Re: [PATCH 0/2] Add rs485 support to uartps driver
>>>
>>> Manikanta Guntupalli wrote 2023-04-26 14:29:
>>> > Add optional gpio property to uartps node to support rs485 Add rs485
>>> > support to uartps driver
>>> >
>>> > Manikanta Guntupalli (2):
>>> >   dt-bindings: Add optional gpio property to uartps node to support
>>> >     rs485
>>> >   tty: serial: uartps: Add rs485 support to uartps driver
>>> >
>>> >  .../devicetree/bindings/serial/cdns,uart.yaml |  5 +
>>> >  drivers/tty/serial/xilinx_uartps.c            | 96 ++++++++++++++++++-
>>> >  2 files changed, 100 insertions(+), 1 deletion(-)
>>>
>>> Why would you want to use a GPIO and not RTS for choosing the direction as
>>> is more common in this case?
>> In ZynqMp platform Cadence UART Controller RTS signal routed to
>> external through the PL(Programmable Logic) design not through
>> Multiplexed IO.
> 
> Then why not route RXD & TXD to the PL as well and connect the module to a
> PMOD connector connected to the PL? But I admit that a GPIO always works as
> well.

I will let Mani to comment other parts. Simply that's how PCB is wired now.
I remember some discussions to enhance silicon with being able to route MIO pins 
to PL but that capability has never been added.
And the second part of it is on PL pin constrained system there doesn't need to 
be free PL pin for this functionality.
And third thing is that routing via PL means that PL has to be loaded to get 
this functionality. Which also means much higher power consumption even if there 
is single wire between EMIO and PL pin.
It means GPIO routed via MIO through free existing pin is PCB design choice in 
the context of project they are focusing on.
And good that you see also GPIO as viable option for it.

Thanks,
Michal