linux-kernel - Re: [PATCH v1 1/1] i2c: scmi: Convert to be a platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 May 2023 07:51:55 +0000
From:   Michael Brunner <michael.brunner@...tron.com>
To:     "josef@...rland.se" <josef@...rland.se>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "wsa@...nel.org" <wsa@...nel.org>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ingmar Klein <Ingmar.Klein@...tron.com>
Subject: Re: [PATCH v1 1/1] i2c: scmi: Convert to be a platform driver

On Thu, 2022-09-08 at 13:02 +0300, Andy Shevchenko wrote:
> On Thu, Sep 08, 2022 at 09:48:29AM +0200, Josef Johansson wrote:
> > On 9/8/22 08:07, Josef Johansson wrote:
> > > On 9/7/22 21:47, Wolfram Sang wrote:
> > > > On Tue, Sep 06, 2022 at 06:55:07PM +0300, Andy Shevchenko
> > > > wrote:
> > > > > ACPI core in conjunction with platform driver core provides
> > > > > an infrastructure to enumerate ACPI devices. Use it in order
> > > > > to remove a lot of boilerplate code.
> > > > > 
> > > > > Signed-off-by: Andy Shevchenko <
> > > > > andriy.shevchenko@...ux.intel.com>
> > > > Josef, do you have resources to test this patch before I apply
> > > > it?
> > > > 
> > > Yes, I'll make that happen today.
> > Hi,
> > 
> > I compiled with linux-6.0.0-rc4 with your patch on top.
> > 
> > Have been running flawless so far. Boot showed no problems.
> > 
> > Thanks!
> 
> Thank you!
> 

Hi,

We just noticed that this change prevents the usage of the i2c-scmi
driver on basically all Kontron COMe based boards.
The reason is the patch "ACPI / platform: Add SMB0001 HID to
forbidden_id_list" submitted in November 2018 by Hans de Goede. The
patch blacklists the SMB0001 HID that is also used by the COMe boards.
This was due to issues with HP AMD based laptops according to the
commit message.
Ironically the commit message there states that it is OK to blacklist
the HID as the device directly binds to the acpi_bus and therefore the
platform_device is not needed anyway. This changed with this patch.

As this affects all systems using this HID, applying a patch that
whitelists specific boards again in the acpi-platform driver doesn't
seem to be a good solution to me.
Therefore I would request to remove this patch again, unless someone
has a better idea.

Thanks,
  Michael Brunner