linux-kernel - Re: [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mfb6xYVrgurL=ZfsNwUT4ghqgOYgg11ij7LjLaVUwJEGg@mail.gmail.com>
Date:   Mon, 15 May 2023 10:01:02 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] pinctrl: qcom: sa8775p: add the wakeirq map

On Sat, May 13, 2023 at 11:26 AM Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
>
>
> On 12.05.2023 17:32, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > The SA8775P TLMM driver is missing the GPIO-to-wakeup-pin mapping. This
> > adds it.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> This almost matches
>
> https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/d7af4a14603957d414e931b5f175f36f3537ae34
>
> minus one diff:
>
> < { 39, 200 },
> ---
> > { 30, 200 },
>

It's my typo, thanks for catching it.

Bartosz

> please consult which one is correct with qc folks
>
> Konrad
> >  drivers/pinctrl/qcom/pinctrl-sa8775p.c | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-sa8775p.c b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > index 2ae7cdca65d3..422d72ed1012 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-sa8775p.c
> > @@ -1491,6 +1491,23 @@ static const struct msm_pingroup sa8775p_groups[] = {
> >       [153] = SDC_QDSD_PINGROUP(sdc1_data, 0x199000, 9, 0),
> >  };
> >
> > +static const struct msm_gpio_wakeirq_map sa8775p_pdc_map[] = {
> > +     { 0, 169 }, { 1, 174 }, { 2, 170 }, { 3, 175 }, { 4, 171 }, { 5, 173 },
> > +     { 6, 172 }, { 7, 182 }, { 10, 220 }, { 11, 213 }, { 12, 221 },
> > +     { 16, 230 }, { 19, 231 }, { 20, 232 }, { 23, 233 }, { 24, 234 },
> > +     { 26, 223 }, { 27, 235 }, { 28, 209 }, { 29, 176 }, { 39, 200 },
> > +     { 31, 201 }, { 32, 212 }, { 35, 177 }, { 36, 178 }, { 39, 184 },
> > +     { 40, 185 }, { 41, 227 }, { 42, 186 }, { 43, 228 }, { 45, 187 },
> > +     { 47, 188 }, { 48, 194 }, { 51, 195 }, { 52, 196 }, { 55, 197 },
> > +     { 56, 198 }, { 57, 236 }, { 58, 192 }, { 59, 193 }, { 72, 179 },
> > +     { 73, 180 }, { 74, 181 }, { 75, 202 }, { 76, 183 }, { 77, 189 },
> > +     { 78, 190 }, { 79, 191 }, { 80, 199 }, { 83, 204 }, { 84, 205 },
> > +     { 85, 229 }, { 86, 206 }, { 89, 207 }, { 91, 208 }, { 94, 214 },
> > +     { 95, 215 }, { 96, 237 }, { 97, 216 }, { 98, 238 }, { 99, 217 },
> > +     { 100, 239 }, { 105, 219 }, { 106, 210 }, { 107, 211 }, { 108, 222 },
> > +     { 109, 203 }, { 145, 225 }, { 146, 226 },
> > +};
> > +
> >  static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> >       .pins = sa8775p_pins,
> >       .npins = ARRAY_SIZE(sa8775p_pins),
> > @@ -1499,6 +1516,8 @@ static const struct msm_pinctrl_soc_data sa8775p_pinctrl = {
> >       .groups = sa8775p_groups,
> >       .ngroups = ARRAY_SIZE(sa8775p_groups),
> >       .ngpios = 150,
> > +     .wakeirq_map = sa8775p_pdc_map,
> > +     .nwakeirq_map = ARRAY_SIZE(sa8775p_pdc_map),
> >  };
> >
> >  static int sa8775p_pinctrl_probe(struct platform_device *pdev)