linux-kernel - GPIO set config argument value difference in pinconf and gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <120117b6-feda-e7aa-4f09-a126a0747388@microchip.com>
Date:   Mon, 15 May 2023 08:21:35 +0000
From:   <Ryan.Wanner@...rochip.com>
To:     <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linus.walleij@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <Claudiu.Beznea@...rochip.com>
Subject: GPIO set config argument value difference in pinconf and gpiolib

Hello,

I have a question about gpiochip_generic_config function. I noticed when
calling this function the pin configuration is incorrect for
push-pull/open-drain in pinctrl-at91-pio4. I traced this down to a
argument value that is incorrect, this is extracted from the config
using pinconf_to_config_argument. The pinctrl driver processes this
config argument value correctly but when gpiolib calls this function
that value is not passed causing the argument to be 0 in the function
atmel_conf_pin_config_group_set. I see this same structure in other
pinctrl drivers as well.

It seems that gpio_set_config is called which hard codes 0 into
gpio_set_config_with_arugment function call making the argument 0 when
passed into the pinctrl set config function. It seems that the correct
way would to mimic the gpio_set_bias function handling of this argument
value. Doing a small local test seems to confirm my suggestion.

Best,
Ryan Wanner