linux-kernel - RE: [PATCH v4 8/8] tty: n_gsm: add DLCI specific rx/tx statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB9PR10MB5881A7A09725EAF8FDB5F35BE0789@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 15 May 2023 10:47:08 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 8/8] tty: n_gsm: add DLCI specific rx/tx statistics

> > From: Daniel Starke <daniel.starke@...mens.com>
> > 
> > Add counters for the number of data bytes received/transmitted per DLCI in
> > for preparation for an upcoming patch which will expose these values to the
> > user.
> 
> As this is patch 8/8, "upcoming patch" makes no sense, sorry.  Please
> either drop this and add it as part of the series that provides this
> functionality, or add the functionality to the patch series as the next
> patch in it.

I will add the remaining two outstanding patches on my side to this patch
series. The functional addition which exposes these values to the user is
included there.

> > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> > index 62bff4474b57..2e2e1dafcf40 100644
> > --- a/drivers/tty/n_gsm.c
> > +++ b/drivers/tty/n_gsm.c
> > @@ -186,6 +186,9 @@ struct gsm_dlci {
> >  	void (*data)(struct gsm_dlci *dlci, const u8 *data, int len);
> >  	void (*prev_data)(struct gsm_dlci *dlci, const u8 *data, int len);
> >  	struct net_device *net; /* network interface, if created */
> > +	/* Statistics (not currently exposed) */
> 
> No blank line before this?

I will add a blank line before this one.

> 
> And why isn't this structure documented in kerneldoc to make it more
> obvious what is happening?

True, it would be better if this was the case. However, there was no such
cleanup of this internal structure yet and this is out of scope of this
patch/patch series. A future patch needs to fix this.


Best regards,
Daniel Starke