linux-kernel - Re: [PATCH wireless v1] wifi: rtw88: sdio: Always use two consecutive bytes for word operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mt25n9ll.fsf@kernel.org>
Date:   Mon, 15 May 2023 13:59:50 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Ping-Ke Shih <pkshih@...ltek.com>
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "tony0620emma\@gmail.com" <tony0620emma@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Rudi Heitbaum <rudi@...tbaum.com>
Subject: Re: [PATCH wireless v1] wifi: rtw88: sdio: Always use two consecutive bytes for word operations

Ping-Ke Shih <pkshih@...ltek.com> writes:

>> -----Original Message-----
>> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
>> Sent: Monday, May 15, 2023 4:04 AM
>> To: linux-wireless@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org; Ping-Ke Shih <pkshih@...ltek.com>; tony0620emma@...il.com;
>> kvalo@...nel.org; Martin Blumenstingl <martin.blumenstingl@...glemail.com>; Larry Finger
>> <Larry.Finger@...inger.net>; Rudi Heitbaum <rudi@...tbaum.com>
>> Subject: [PATCH wireless v1] wifi: rtw88: sdio: Always use two consecutive bytes for word operations
>> 
>> The Allwinner sunxi-mmc controller cannot handle word (16 bit)
>> transfers. So and sdio_{read,write}w fails with messages like the
>> following example using an RTL8822BS (but the same problems were also
>> observed with RTL8822CS and RTL8723DS chips):
>>   rtw_8822bs mmc1:0001:1: Firmware version 27.2.0, H2C version 13
>>   sunxi-mmc 4021000.mmc: unaligned scatterlist: os f80 length 2
>>   sunxi-mmc 4021000.mmc: map DMA failed
>>   rtw_8822bs mmc1:0001:1: sdio read16 failed (0x10230): -22
>> 
>> Use two consecutive single byte accesses for word operations instead. It
>> turns out that upon closer inspection this is also what the vendor
>> driver does, even though it does have support for sdio_{read,write}w. So
>> we can conclude that the rtw88 chips do support word access but only on
>> SDIO controllers that also support it. Since there's no way to detect if
>> the controller supports word access or not the rtw88 sdio driver
>> switches to the easiest approach: avoiding word access.
>> 
>> Reported-by: Larry Finger <Larry.Finger@...inger.net>
>> Closes: https://lore.kernel.org/linux-wireless/527585e5-9cdd-66ed-c3af-6da162f4b720@lwfinger.net/
>
> "Closes:" seems not a regular tag. Use "Link: " instead.

Actually the documentation now talks about Closes tag:

https://docs.kernel.org/process/5.Posting.html#patch-formatting-and-changelogs

I guess this tag is a recent addition?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches