linux-kernel - Re: [PATCH 0/2] ovl: Fix null ptr dereference at realinode in rcu-walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230515-befestigen-stopfen-ab8100cb6a00@brauner>
Date:   Mon, 15 May 2023 13:04:58 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     miklos@...redi.hu, amir73il@...il.com,
        linux-unionfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] ovl: Fix null ptr dereference at realinode in
 rcu-walk

On Fri, May 05, 2023 at 08:24:50PM +0800, Zhihao Cheng wrote:
> Zhihao Cheng (2):
>   ovl: get_acl: Fix null pointer dereference at realinode in rcu-walk
>     mode
>   ovl: ovl_permission: Fix null pointer dereference at realinode in
>     rcu-walk mode
> 
>  fs/overlayfs/inode.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Seems fine to me. Thanks for fixing this,
Reviewed-by: Christian Brauner <brauner@...nel.org>

(One thing that might be possible is to move this into a tiny static
inline helper but might not be worth it.)