linux-kernel - Re: [PATCH] serial: 8250: omap: Move uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230515122356.GI14287@atomide.com>
Date:   Mon, 15 May 2023 15:23:56 +0300
From:   Tony Lindgren <tony@...mide.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250: omap: Move uart_write() inside PM section

* Geert Uytterhoeven <geert@...ux-m68k.org> [230515 06:57]:
> If CONFIG_PM is not set (e.g. m68k/allmodconfig):
> 
>     drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function]
>       169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val)
> 	  |             ^~~~~~~~~~
> 
> Fix tis by moving uart_write() inside the existing section protected
> by #ifdef CONFIG_PM.

OK thanks for fixing it:

Reviewed-by: Tony Lindgren <tony@...mide.com>