linux-kernel - Re: selftests: mincore: mincore_selftest fails only on qemu-armv7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aab36e10-ce86-9374-ea67-be6d1a0f4adf@collabora.com>
Date:   Mon, 15 May 2023 14:32:22 +0200
From:   Ricardo Cañuelo <ricardo.canuelo@...labora.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     open list <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, lkft-triage@...ts.linaro.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Ard Biesheuvel <ardb@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Anders Roxell <anders.roxell@...aro.org>
Subject: Re: selftests: mincore: mincore_selftest fails only on qemu-armv7

Hi all,

On 15/5/23 13:51, Dan Carpenter wrote:
> The test is wrong.  It doesn't accept -EINVAL as a valid failure.
> 
> tools/testing/selftests/mincore/mincore_selftest.c
>     139  TEST(check_huge_pages)
>     140  {
>     141          unsigned char vec[1];
>     142          char *addr;
>     143          int retval;
>     144          int page_size;
>     145
>     146          page_size = sysconf(_SC_PAGESIZE);
>     147
>     148          errno = 0;
>     149          addr = mmap(NULL, page_size, PROT_READ | PROT_WRITE,
>     150                  MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,
>     151                  -1, 0);
>     152          if (addr == MAP_FAILED) {
>     153                  if (errno == ENOMEM)
> 
> On Armv7 is a 32bit machine so HUGETLB isn't enabled and the errno can
> be -EINVAL.  It's has returned this for 10 years.
> 
>     154                          SKIP(return, "No huge pages available.");
>     155                  else
>     156                          TH_LOG("mmap error: %s", strerror(errno));
>     157          }
>     158          retval = mincore(addr, page_size, vec);
>     159          ASSERT_EQ(0, retval);
> 
> mm/mmap.c
>    1405                  }
>    1406          } else if (flags & MAP_HUGETLB) {
>    1407                  struct hstate *hs;
>    1408
>    1409                  hs = hstate_sizelog((flags >> MAP_HUGE_SHIFT) & MAP_HUGE_MASK);
>    1410                  if (!hs)
>    1411                          return -EINVAL;
>                                  ^^^^^^^^^^^^^^^
> hstate_sizelog() return NULL when CONFIG_HUGETLB_PAGE is disabled.
> 
>    1412
>    1413                  len = ALIGN(len, huge_page_size(hs));
> 
> regards,
> dan carpenter
> 

Thanks for the tip, Dan. I'll send a patch for it asap.

Cheers,
Ricardo