linux-kernel - Re: [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc4d10f2-6ded-bed3-1d81-7e09292adf6f@mailbox.org>
Date:   Mon, 15 May 2023 15:04:43 +0200
From:   Michel Dänzer <michel.daenzer@...lbox.org>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     felipe.clark@....com, Aric.Cyr@....com, wenjing.liu@....com,
        dri-devel@...ts.freedesktop.org, Jun.Lei@....com,
        airlied@...il.com, jiapeng.chong@...ux.alibaba.com,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        amd-gfx@...ts.freedesktop.org, aurabindo.pillai@....com,
        Alvin.Lee2@....com, harry.wentland@....com, sunpeng.li@....com,
        mwen@...lia.com, Daniel Wheeler <daniel.wheeler@....com>,
        Dillon.Varone@....com, Wesley Chalmers <Wesley.Chalmers@....com>,
        qingqing.zhuo@....com, Xinhui.Pan@....com, daniel@...ll.ch,
        Alex Deucher <alexander.deucher@....com>,
        christian.koenig@....com
Subject: Re: [PATCH AUTOSEL 6.1 4/9] drm/amd/display: Do not set drr on pipe
 commit

On 5/11/23 21:39, Sasha Levin wrote:
> From: Wesley Chalmers <Wesley.Chalmers@....com>
> 
> [ Upstream commit 474f01015ffdb74e01c2eb3584a2822c64e7b2be ]
> 
> [WHY]
> Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a
> pipe commit can cause underflow.
> 
> [HOW]
> Move DMUB p-state delegate into optimze_bandwidth; enabling FAMS sets
> optimized_required.
> 
> This change expects that Freesync requests are blocked when
> optimized_required is true.

This change caused a regression, see https://patchwork.freedesktop.org/patch/532240/?series=116487&rev=1#comment_972234 / 9deeb132-a317-7419-e9da-cbc0a379c0eb@...nzer.net .


-- 
Earthling Michel Dänzer            |                  https://redhat.com
Libre software enthusiast          |         Mesa and Xwayland developer