[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZGIu+tmiMRH64luT@kuha.fi.intel.com>
Date: Mon, 15 May 2023 16:09:14 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Tom Rix <trix@...hat.com>
Cc: bryan.odonoghue@...aro.org, linux@...ck-us.net, agross@...nel.org,
andersson@...nel.org, konrad.dybcio@...aro.org,
gregkh@...uxfoundation.org, linux-arm-msm@...r.kernel.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: qcom: set pm8150b_typec_res
storage-class-specifier to static
On Mon, May 15, 2023 at 07:40:43AM -0400, Tom Rix wrote:
> smatch reports
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
> 'pm8150b_typec_res' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static
>
> Signed-off-by: Tom Rix <trix@...hat.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c
> index 191458ce4a06..937e855a6c4c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c
> @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = {
> .nr_irqs = 7,
> };
>
> -struct pmic_typec_resources pm8150b_typec_res = {
> +static struct pmic_typec_resources pm8150b_typec_res = {
> .pdphy_res = &pm8150b_pdphy_res,
> .port_res = &pm8150b_port_res,
> };
--
heikki
Powered by blists - more mailing lists