linux-kernel - Re: [PATCH net-next 5/7] net: lan966x: Add support for offloading default prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZGJQEy+zFFfCdDRm@nimitz>
Date:   Mon, 15 May 2023 17:30:27 +0200
From:   Piotr Raczynski <piotr.raczynski@...el.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next 5/7] net: lan966x: Add support for offloading
 default prio

On Sun, May 14, 2023 at 10:10:27PM +0200, Horatiu Vultur wrote:
> Add support for offloading default prio.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>

...

> @@ -106,6 +111,13 @@ static int lan966x_dcb_app_validate(struct net_device *dev,
>  	int err = 0;
>  
>  	switch (app->selector) {
> +	/* Default priority checks */
> +	case IEEE_8021QAZ_APP_SEL_ETHERTYPE:
> +		if (app->protocol != 0)
nit, you can just do: if (app->protocol)

> +			err = -EINVAL;
> +		else if (app->priority >= NUM_PRIO_QUEUES)
> +			err = -ERANGE;
> +		break;

...