linux-kernel - Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 May 2023 10:24:11 -0500
From:   Andrew Davis <afd@...com>
To:     <andy.shevchenko@...il.com>
CC:     Peter Tyser <ptyser@...-inc.com>,
        Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to simplify
 remove path

On 5/15/23 1:34 PM, andy.shevchenko@...il.com wrote:
> Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
>> Use devm version of gpiochip add function to handle removal for us.
>>
>> While here update copyright and module author.
> 
> ...
> 
>> +static void pisosr_mutex_destroy(void *data)
>> +{
>> +	struct mutex *lock = data;
>> +
>> +	mutex_destroy(lock);
>> +}
> 
> No need to cast void * explicitly.
> 

No need sure, but I really think it looks cleaner to be
explicit with the types here. If you feel strongly I
can change it though.

Andrew

> static void pisosr_mutex_destroy(void *lock)
> {
> 	mutex_destroy(lock);
> }
>