linux-kernel - Re: [PATCH v3 0/3] ovl: Fix null ptr dereference at realinode in rcu-walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230516-topografie-gejubelt-dba162b6e735@brauner>
Date:   Tue, 16 May 2023 17:42:33 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     miklos@...redi.hu, amir73il@...il.com,
        linux-unionfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] ovl: Fix null ptr dereference at realinode in
 rcu-walk

On Tue, May 16, 2023 at 10:16:16PM +0800, Zhihao Cheng wrote:
> v1->v2:
>   Extract a helper to get realpath and real inode from ovl inode.
>   Get realinode from realpath in do_ovl_get_acl().
> v2->v3:
>   Modify original helper ovl_i_path_real() to return the realinode.
> 
> Zhihao Cheng (3):
>   ovl: Let helper ovl_i_path_real() return the realinode
>   ovl: ovl_permission: Fix null pointer dereference at realinode in
>     rcu-walk mode
>   ovl: get_acl: Fix null pointer dereference at realinode in rcu-walk
>     mode
> 
>  fs/overlayfs/inode.c     | 17 ++++++++---------
>  fs/overlayfs/overlayfs.h |  2 +-
>  fs/overlayfs/util.c      |  7 ++++---
>  3 files changed, 13 insertions(+), 13 deletions(-)

Looks good to me,
Reviewed-by: Christian Brauner <brauner@...nel.org>