[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMj1kXFTYo0HvP3izv2tgewCBT37LG0hgXKvn8zSmNfB0kUFHQ@mail.gmail.com>
Date: Tue, 16 May 2023 19:17:07 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Mark Rutland <mark.rutland@....com>,
Marc Zyngier <maz@...nel.org>,
Oliver Upton <oliver.upton@...ux.dev>,
James Morse <james.morse@....com>,
Suzuki K Poulose <suzuki.poulose@....com>,
Zenghui Yu <yuzenghui@...wei.com>,
Anshuman Khandual <anshuman.khandual@....com>,
Kees Cook <keescook@...omium.org>,
Suren Baghdasaryan <surenb@...gle.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-efi@...r.kernel.org, kvmarm@...ts.linux.dev
Subject: Re: [PATCH 00/15] arm64: address -Wmissing-prototype warnings
On Tue, 16 May 2023 at 18:06, Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> This addresses all arm64 specific protype warnings. As with the arm32
> patches, the majority of them should be straightforward, either adding
> an #include statement to get the right header, or ensuring that an unused
> global function is left out of the build when the prototype is hidden.
>
> The ones that are a bit awkward are those that just add a prototype to
> shut up the warning, but the prototypes are never used for calling the
> function because the only caller is in assembler code. I tried to come
> up with other ways to shut up the compiler, and ideally this would be
> triggered by the 'asmlinkage' keyword as Ard suggested in the past, but
> I could not come up with a way to do this.
>
> All of the warnings have to be addressed in some form before the
> warning can be enabled by default.
>
> Arnd
>
> Link: https://people.kernel.org/arnd/missing-prototype-warnings-in-the-kernel
>
For the record, as I mentioned a while ago, I think it is a bit
disappointing that we cannot teach the compiler that 'asmlinkage'
functions don't need a prototype. But I don't have any objections to
these changes, so
Acked-by: Ard Biesheuvel <ardb@...nel.org>
>
> Arnd Bergmann (15):
> arm64: xor-neon: mark xor_arm64_neon_*() static
> arm64: add scs_patch_vmlinux prototype
> arm64: avoid prototype warnings for syscalls
> arm64: move cpu_suspend_set_dbg_restorer() prototype to header
> arm64: spectre: provide prototypes for internal functions
> arm64: kvm: add prototypes for functions called in asm
> arm64: cpuidle: fix #ifdef for acpi functions
> arm64: efi: add efi_handle_corrupted_x18 prototype
> arm64: hide unused is_valid_bugaddr()
> arm64: module-plts: inline linux/moduleloader.h
> arm64: flush: include linux/libnvdimm.h
> arm64: kaslr: add kaslr_early_init() declaration
> arm64: signal: include asm/exception.h
> arm64: move early_brk64 prototype to header
> arm64: add alt_cb_patch_nops prototype
>
> arch/arm64/include/asm/alternative.h | 3 +++
> arch/arm64/include/asm/archrandom.h | 2 ++
> arch/arm64/include/asm/compat.h | 2 ++
> arch/arm64/include/asm/efi.h | 2 ++
> arch/arm64/include/asm/hw_breakpoint.h | 8 ++++++++
> arch/arm64/include/asm/kvm_asm.h | 18 ++++++++++++++++++
> arch/arm64/include/asm/scs.h | 1 +
> arch/arm64/include/asm/spectre.h | 16 ++++++++++++++++
> arch/arm64/include/asm/syscall_wrapper.h | 4 ++++
> arch/arm64/include/asm/traps.h | 2 ++
> arch/arm64/kernel/cpuidle.c | 2 +-
> arch/arm64/kernel/hw_breakpoint.c | 8 --------
> arch/arm64/kernel/module-plts.c | 1 +
> arch/arm64/kernel/signal.c | 1 +
> arch/arm64/kernel/traps.c | 3 ++-
> arch/arm64/lib/xor-neon.c | 8 ++++----
> arch/arm64/mm/fault.c | 3 ---
> arch/arm64/mm/flush.c | 1 +
> 18 files changed, 68 insertions(+), 17 deletions(-)
>
> --
> 2.39.2
>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Oliver Upton <oliver.upton@...ux.dev>
> Cc: James Morse <james.morse@....com>
> Cc: Suzuki K Poulose <suzuki.poulose@....com>
> Cc: Zenghui Yu <yuzenghui@...wei.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-efi@...r.kernel.org
> Cc: kvmarm@...ts.linux.dev
>
Powered by blists - more mailing lists