linux-kernel - Re: [PATCH] wifi: b43: fix incorrect _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b53f3673-f6b1-4071-9bcf-9ae5815593eb@app.fastmail.com>
Date:   Tue, 16 May 2023 19:45:16 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     Michael Büsch <m@...s.ch>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Kalle Valo" <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Tom Rix" <trix@...hat.com>, linux-wireless@...r.kernel.org,
        b43-dev@...ts.infradead.org, Netdev <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] wifi: b43: fix incorrect __packed annotation

On Tue, May 16, 2023, at 19:12, Michael Büsch wrote:
> On Tue, 16 May 2023 09:45:42 +0200
> Arnd Bergmann <arnd@...nel.org> wrote:
>
>> b43_iv { union {
>>  		__be16 d16;
>>  		__be32 d32;
>> -	} data __packed;
>> +	} __packed data;
>>  } __packed;
>>  
>>  
>
> Oh, interesting. This has probably been there forever.
> Did you check if the b43legacy driver has the same issue?

I had not checked, but I see that it does have the same bug.

I only sent this one because the build bot (incorrectly)
blamed one of my recent patches for a regression here.
Which reminds me that I was missing:

Reported-by: kernel test robot <lkp@...el.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305160749.ay1HAoyP-lkp@intel.com/

Should I resend this as a combined patch for both drivers?

   Arnd